fix(azure): stuck self-hosted Azure SSO installation setup #18638
Open
aldy505 wants to merge 1 commit into
Open
fix(azure): stuck self-hosted Azure SSO installation setup #18638aldy505 wants to merge 1 commit into
aldy505 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| 1. Log in to your self-hosted Sentry instance using your existing account — we'll call this User A. | ||
| 2. Ask someone else to log in through SSO and confirm it creates a new account for them — we'll call this User B. | ||
| 3. User A needs to assign the "Owner" role to User B. | ||
| 4. User B needs to remove User A's account from the Sentry instance. |
Contributor
There was a problem hiding this comment.
Bug: The SSO workaround documentation instructs an admin to remove a user account without warning that this action is destructive and causes irreversible data loss.
Severity: HIGH
Suggested Fix
Add a prominent warning or callout in the documentation before the step that instructs the administrator to remove the user account. This warning should clearly state that the action is destructive, irreversible, and will result in the permanent loss of all data associated with that user account.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: docs/organization/authentication/sso/azure-sso.mdx#L91
Potential issue: The documentation for an Azure SSO workaround instructs an
administrator to remove a user's account from the Sentry instance as part of the
process. However, it fails to include a warning that this is a destructive and
irreversible action. Performing this step will result in the permanent loss of the
user's associated data, including API tokens, saved searches, and dashboards. The
subsequent step involves creating a new account via SSO, not restoring the original one,
making the data loss permanent.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Closes getsentry/self-hosted#4244
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: