fix(dotnet): clarify ASP.NET trace propagation vs. transactions#18622
Open
jamescrosswell wants to merge 2 commits into
Open
fix(dotnet): clarify ASP.NET trace propagation vs. transactions#18622jamescrosswell wants to merge 2 commits into
jamescrosswell wants to merge 2 commits into
Conversation
The trace-propagation how-to for .NET told ASP.NET (System.Web) users to call `Context.StartOrContinueTrace()` in `Application_BeginRequest`, but that method only continues/propagates the trace and never starts a transaction. Users following this page in place of the getting-started config lost their transactions (getsentry/sentry-dotnet#3888). Document both options: `StartSentryTransaction`/`FinishSentryTransaction` (recommended — continues the trace and creates transactions) and `StartOrContinueTrace` (propagation only), and warn against using both. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
jamescrosswell
commented
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Fixes the misleading .NET trace-propagation docs reported in getsentry/sentry-dotnet#3888.
The Trace Propagation page told ASP.NET (System.Web) users to call
Context.StartOrContinueTrace()inApplication_BeginRequest. That method only continues/propagates an incoming trace — it never starts a transaction. Users who followed this page in place of the getting-started config (which usesStartSentryTransaction) found that transactions stopped showing up in Sentry.StartSentryTransactioninApplication_BeginRequest+FinishSentryTransactioninApplication_EndRequest, which continues the incoming trace and creates transactions.StartOrContinueTraceas the propagation-only option (when you don't want this app to create its own transactions/spans).IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: