-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
docs(dart): Document stream mode in integration guides #18610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
buenaflor
wants to merge
13
commits into
buenaflor/docs/dart-span-streaming-new-spans
Choose a base branch
from
buenaflor/docs/dart-span-streaming-integrations
base: buenaflor/docs/dart-span-streaming-new-spans
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+283
−27
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
920f5ca
docs(dart): Add New Spans and migration guide for span streaming
buenaflor 9cd2a26
docs(dart): Correct stream mode sampling and beforeSendSpan details
buenaflor 4de3378
docs(dart): Bump span streaming min SDK version to 9.23.0
buenaflor 0ea555c
docs(dart): Document array attributes and startSpanSync signature
buenaflor 544dec8
docs(dart): Correct SentrySpanStatusV2 possible values
buenaflor 01e519e
docs(dart): Revert span status to ok/error only
buenaflor 2af0ee3
docs(dart): Note scope tags don't apply to spans in stream mode
buenaflor d2fe1e8
docs(dart): Add stream mode callout to integration pages
buenaflor 496b153
docs(dart): Add inline stream mode hints to integration snippets
buenaflor 6143fa6
docs(dart): Add stream mode tabs to integration instrumentation snippets
buenaflor ce6b01b
docs(dart): Reference startSpan()/startSpanSync() with parens in prose
buenaflor 6052a61
update span page link; minor wording updates
inventarSarah 4b427cc
delete unused folder
inventarSarah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The
sentryResponseDecoderStream Mode example accepts ahubparameter but ignores it, using the globalSentryobject instead.Severity: LOW
Suggested Fix
Modify the
sentryResponseDecoderStream Mode example to use thehubparameter when it's provided, similar to the Transaction Mode example. Specifically, replaceSentry.startSpanSync(...)with a call that utilizes thehubobject, such as(hub ?? HubAdapter()).startSpanSync(...).Prompt for AI Agent
Did we get this right? 👍 / 👎 to inform future reviews.