feat(attributes): Add gcp.function.context.* span attributes#371
Open
chargome wants to merge 3 commits into
Open
feat(attributes): Add gcp.function.context.* span attributes#371chargome wants to merge 3 commits into
gcp.function.context.* span attributes#371chargome wants to merge 3 commits into
Conversation
Add GCP Cloud Function context attributes: type, source, id, specversion, time, eventId, timestamp, eventType, and resource. Needed by the JS SDK (JS-2221) for span streaming. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Bug Fixes 🐛Attributes
Other
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Rename gcp.function.context.eventId to event_id and eventType to event_type to comply with the repo's snake_case naming policy. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
chargome
requested review from
a team,
Lms24,
cleptric,
mjq and
nsdeschenes
as code owners
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+7
to
+17
| }, | ||
| "is_in_otel": false, | ||
| "example": "1234567890", | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [363], | ||
| "description": "Added gcp.function.context.id attribute" | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
Bug: The documentation for gcp.function.context.id and gcp.function.context.event_id lacks clarity, failing to distinguish between the current CloudEvents (2nd gen) and legacy (1st gen) formats.
Severity: LOW
Suggested Fix
Update the brief description for gcp.function.context.id to clarify that it corresponds to the CloudEvents 2nd generation format. For example: "The CloudEvents (2nd gen) ID of the GCP Cloud Function event." This will clearly distinguish it from the legacy gcp.function.context.event_id attribute.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: model/attributes/gcp/gcp__function__context__id.json#L1-L17
Potential issue: The attributes `gcp.function.context.id` and
`gcp.function.context.event_id` both represent a GCP Cloud Function event ID. However,
the documentation does not clearly state that `id` is for the current CloudEvents (2nd
gen) format, while `event_id` is for the legacy (1st gen) format. This ambiguity,
compounded by identical example values, could lead developers of downstream SDKs to
select the incorrect attribute, potentially causing functional issues when parsing or
processing event data.
Also affects:
model/attributes/gcp/gcp__function__context__event_id.json:1~17
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
type,source,id,specversion,time,eventId,timestamp,eventType,resourceeventId,eventType, andtimestampuse camelCase to match the GCP API field names