ref(spanv2): Normalize client sample rates in attributes#6010
Open
Dav1dde wants to merge 1 commit into
Open
Conversation
Dav1dde
force-pushed
the
dav1d/validate-sample-rates
branch
from
f28f1ff to
783f291
Compare
loewenheim
reviewed
May 20, 2026
| attributes.insert("sentry.server_sample_rate", server_sample_rate.to_f64()); | ||
| attributes.insert( | ||
| "sentry.server_sample_rate", | ||
| server_sample_rate.to_f64().clamp(1e-9, 1.0), |
Contributor
There was a problem hiding this comment.
Since measurements conversion is at the front of my brain right now: should the same thing happen during v1 -> v2 span conversion?
Member
Author
There was a problem hiding this comment.
Yeah it would be good if we could normalize in all places, it's just a bit of a pain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalize a client sample rate to be valid.