Skip to content

fix non-constant format string in call go1.24 error#649

Closed
jay-418 wants to merge 1 commit into
thomas/unbounded-otelfrom
jay/fstring1.24
Closed

fix non-constant format string in call go1.24 error#649
jay-418 wants to merge 1 commit into
thomas/unbounded-otelfrom
jay/fstring1.24

Conversation

@jay-418

@jay-418 jay-418 commented May 19, 2025

Copy link
Copy Markdown
Contributor

fixes the more stringent go vet fstring checks introduced with go1.24

@jay-418 jay-418 requested a review from thomasjib May 19, 2025 23:13
@jay-418

jay-418 commented May 19, 2025

Copy link
Copy Markdown
Contributor Author

@thomasjib I committed this separately to clear these fstring errors off while we work on the assembly problems from https://github.com/getlantern/engineering/issues/2177

@thomasjib

Copy link
Copy Markdown
Contributor

@jay-418 does it work to just bring these changes into #648? This seems like a better fix than what I had, and the other piece seems to be working

@jay-418

jay-418 commented May 27, 2025

Copy link
Copy Markdown
Contributor Author

@jay-418 does it work to just bring these changes into #648? This seems like a better fix than what I had, and the other piece seems to be working

Sorry for the slow reply, but 💯 absolutely.

@thomasjib

Copy link
Copy Markdown
Contributor

Sounds good, I added that into this PR

@thomasjib thomasjib closed this May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants