-
Notifications
You must be signed in to change notification settings - Fork 8
Add offline-mode init via DITTO_OFFLINE_LICENSE_TOKEN across quickstart apps #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Brian Plattenburg (bplattenburg)
wants to merge
7
commits into
main
Choose a base branch
from
add-offline-mode-license-token
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1467149
Add offline-mode init via DITTO_OFFLINE_LICENSE_TOKEN across quickstarts
bplattenburg 78c2eaf
Fix offline-mode build issues found during local validation
bplattenburg ec36a71
Drop unused nullable annotation in dotnet-tui DittoModeSelector
bplattenburg 770c2fe
Add cleanup step to v5 follow-up plan
bplattenburg bf2db83
Fix MauiProgram.cs whitespace per dotnet format
bplattenburg d1b814c
Share DittoMode.cs with dotnet-winforms IntegrationTest
bplattenburg c7d5fc1
Address Copilot review: validate online-mode creds, allow Android off…
bplattenburg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
android-java/app/src/main/java/com/example/dittotasks/DittoMode.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| package com.example.dittotasks; | ||
|
|
||
| /** | ||
| * Identity-mode selection based on env vars. | ||
| * | ||
| * Non-empty {@code DITTO_OFFLINE_LICENSE_TOKEN} (after trim) selects {@link #OFFLINE}; | ||
| * otherwise the app uses {@link #ONLINE_PLAYGROUND}. | ||
| */ | ||
| public enum DittoMode { | ||
| ONLINE_PLAYGROUND, | ||
| OFFLINE; | ||
|
|
||
| public static DittoMode select(String offlineLicenseToken) { | ||
| if (offlineLicenseToken == null) { | ||
| return ONLINE_PLAYGROUND; | ||
| } | ||
| return offlineLicenseToken.trim().isEmpty() ? ONLINE_PLAYGROUND : OFFLINE; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
android-java/app/src/test/java/com/example/dittotasks/DittoModeTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| package com.example.dittotasks; | ||
|
|
||
| import static org.junit.Assert.assertEquals; | ||
|
|
||
| import org.junit.Test; | ||
|
|
||
| public class DittoModeTest { | ||
| @Test | ||
| public void nullTokenSelectsOnline() { | ||
| assertEquals(DittoMode.ONLINE_PLAYGROUND, DittoMode.select(null)); | ||
| } | ||
|
|
||
| @Test | ||
| public void emptyTokenSelectsOnline() { | ||
| assertEquals(DittoMode.ONLINE_PLAYGROUND, DittoMode.select("")); | ||
| } | ||
|
|
||
| @Test | ||
| public void whitespaceOnlyTokenSelectsOnline() { | ||
| assertEquals(DittoMode.ONLINE_PLAYGROUND, DittoMode.select(" \t\n ")); | ||
| } | ||
|
|
||
| @Test | ||
| public void nonEmptyTokenSelectsOffline() { | ||
| assertEquals(DittoMode.OFFLINE, DittoMode.select("any-real-license-token")); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
android-kotlin/QuickStartTasks/app/src/main/java/live/ditto/quickstart/tasks/DittoMode.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| package live.ditto.quickstart.tasks | ||
|
|
||
| /** | ||
| * Identity-mode selection based on env vars. | ||
| * | ||
| * Non-empty `DITTO_OFFLINE_LICENSE_TOKEN` (after trim) selects [OFFLINE]; | ||
| * otherwise the app uses [ONLINE_PLAYGROUND]. | ||
| */ | ||
| enum class DittoMode { | ||
| ONLINE_PLAYGROUND, | ||
| OFFLINE; | ||
|
|
||
| companion object { | ||
| fun select(offlineLicenseToken: String?): DittoMode = | ||
| if (offlineLicenseToken.isNullOrBlank()) ONLINE_PLAYGROUND else OFFLINE | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.