feat: add hold invoices support for LND & LDK

constants/constants.go

@@ -9,6 +9,7 @@ const (
 	TRANSACTION_STATE_PENDING = "PENDING"
 	TRANSACTION_STATE_SETTLED = "SETTLED"
 	TRANSACTION_STATE_FAILED  = "FAILED"
+	TRANSACTION_STATE_ACCEPTED = "ACCEPTED"
 )
 
 const (
@@ -37,6 +38,7 @@ const (
 	LOOKUP_INVOICE_SCOPE    = "lookup_invoice"
 	LIST_TRANSACTIONS_SCOPE = "list_transactions"
 	SIGN_MESSAGE_SCOPE      = "sign_message"
+	HOLD_INVOICES_SCOPE     = "hold_invoices" // covers all hold invoice operations (make/settle/cancel)
 	NOTIFICATIONS_SCOPE     = "notifications" // covers all notification types
 	SUPERUSER_SCOPE         = "superuser"
 )

fly.toml

@@ -1,39 +1,41 @@
-# fly.toml app configuration file generated for nwc on 2024-01-30T12:30:13+01:00
+# fly.toml app configuration file generated for hub-test-dupa on 2025-03-07T17:46:20+01:00
 #
 # See https://fly.io/docs/reference/configuration/ for information about how to use this file.
 #
 
-app = 'nwc'
-primary_region = 'lax'
+app = 'hub-test-dupa'
+primary_region = 'dfw'
+kill_timeout = '2m0s'
 swap_size_mb = 2048
-kill_timeout = 120
 
 [build]
-  image = 'ghcr.io/getalby/hub:latest'
+  image = 'ghcr.io/getalby/hub:v1.14.3'
 
 [env]
-  DATABASE_URI = '/data/nwc.db'
+#  DATABASE_URI = '/data/nwc.db'
   LDK_LOG_LEVEL = '3'
-  LOG_LEVEL = '4'
+  LOG_LEVEL = '5'
   WORK_DIR = '/data'
-
-[[mounts]]
-  source = 'nwc_data'
-  destination = '/data'
-  initial_size = '1'
-  auto_extend_size_threshold = 80
-  auto_extend_size_increment = "1GB"
-  auto_extend_size_limit = "5GB"
-
+  DATABASE_URI = 'postgres://nwc13820861fa:x63Qjndnp2Am@hub-db-lax.internal:5432/nwc13820861fa?sslmode=disable'
+  ALBY_OAUTH_CLIENT_ID = 'Q6VIubLWWF'
+  ALBY_OAUTH_CLIENT_SECRET = 'jytdjU1uLQyGPlEKwlOW'
+  BASE_URL = 'https://my.albyhub.com'
+  FLY_PROCESS_GROUP = 'app'
+  LDK_ESPLORA_SERVER = 'https://electrs.getalbypro.com'
+  LDK_GOSSIP_SOURCE = ''
+  LDK_TRANSIENT_NETWORK_GRAPH = 'true'
+  LDK_VSS_URL = 'https://vss.getalbypro.com/vss'
+  LOG_EVENTS = 'true'
+  LOG_TO_FILE = 'false'
 [http_service]
   internal_port = 8080
   force_https = true
-  auto_stop_machines = false
+  auto_stop_machines = 'off'
   auto_start_machines = true
   min_machines_running = 0
-  processes = ['app']
+#  processes = ['app']
 
 [[vm]]
+  memory = '512mb'
   cpu_kind = 'shared'
   cpus = 1
-  memory = '512mb'

frontend/src/screens/apps/NewApp.tsx

@@ -129,6 +129,14 @@ const NewAppInternal = ({ capabilities }: NewAppInternalProps) => {
     if (requestMethodsSet.has("make_invoice")) {
       scopes.push("make_invoice");
     }
+    // Add check for hold invoice methods
+    if (
+      requestMethodsSet.has("make_hold_invoice") ||
+      requestMethodsSet.has("settle_hold_invoice") ||
+      requestMethodsSet.has("cancel_hold_invoice")
+    ) {
+      scopes.push("hold_invoices");
+    }
     if (requestMethodsSet.has("lookup_invoice")) {
       scopes.push("lookup_invoice");
     }

frontend/src/types.ts

@@ -1,5 +1,6 @@
 import {
   BellIcon,
+  CirclePauseIcon,
   CirclePlusIcon,
   CrownIcon,
   HandCoinsIcon,
@@ -24,7 +25,10 @@ export type Nip47RequestMethod =
   | "list_transactions"
   | "sign_message"
   | "multi_pay_invoice"
-  | "multi_pay_keysend";
+  | "multi_pay_keysend"
+  | "make_hold_invoice"
+  | "settle_hold_invoice"
+  | "cancel_hold_invoice";
 
 export type BudgetRenewalType =
   | "daily"
@@ -39,6 +43,7 @@ export type Scope =
   | "get_balance"
   | "get_info"
   | "make_invoice"
+  | "hold_invoices"
   | "lookup_invoice"
   | "list_transactions"
   | "sign_message"
@@ -57,6 +62,7 @@ export const scopeIconMap: ScopeIconMap = {
   list_transactions: NotebookTabsIcon,
   lookup_invoice: SearchIcon,
   make_invoice: CirclePlusIcon,
+  hold_invoices: CirclePauseIcon,
   pay_invoice: HandCoinsIcon,
   sign_message: PenLineIcon,
   notifications: BellIcon,
@@ -84,6 +90,7 @@ export const scopeDescriptions: Record<Scope, string> = {
   lookup_invoice: "Lookup status of invoices",
   make_invoice: "Create invoices",
   pay_invoice: "Send payments",
+  hold_invoices: "Create, settle & cancel hold invoices",
   sign_message: "Sign messages",
   notifications: "Receive wallet notifications",
   superuser: "Create other app connections",

lnclient/cashu/cashu.go

@@ -120,6 +120,18 @@ func (cs *CashuService) MakeInvoice(ctx context.Context, amount int64, descripti
 	return cs.cashuMintQuoteToTransaction(mintQuote), nil
 }
 
+func (cs *CashuService) MakeHoldInvoice(ctx context.Context, amount int64, description string, descriptionHash string, expiry int64, paymentHash string) (transaction *lnclient.Transaction, err error) {
+	return nil, errors.New("not implemented")
+}
+
+func (cs *CashuService) SettleHoldInvoice(ctx context.Context, preimage string) (err error) {
+	return errors.New("not implemented")
+}
+
+func (cs *CashuService) CancelHoldInvoice(ctx context.Context, paymentHash string) (err error) {
+	return errors.New("not implemented")
+}
+
 func (cs *CashuService) LookupInvoice(ctx context.Context, paymentHash string) (transaction *lnclient.Transaction, err error) {
 	mintQuote := cs.getMintQuoteByPaymentHash(paymentHash)
 	if mintQuote != nil {

lnclient/ldk/ldk.go

@@ -1866,6 +1866,18 @@ func (ls *LDKService) ExecuteCustomNodeCommand(ctx context.Context, command *lnc
 	return nil, nil
 }
 
+func (ls *LDKService) MakeHoldInvoice(ctx context.Context, amount int64, description string, descriptionHash string, expiry int64, paymentHash string) (*lnclient.Transaction, error) {
+	return nil, errors.New("make_hold_invoice is not yet implemented for LDK")
+}
+
+func (ls *LDKService) CancelHoldInvoice(ctx context.Context, paymentHash string) error {
+	return errors.New("cancel_hold_invoice is not yet implemented for LDK")
+}
+
+func (ls *LDKService) SettleHoldInvoice(ctx context.Context, preimage string) error {
+	return errors.New("settle_hold_invoice is not yet implemented for LDK")
+}
+
 func GetVssNodeIdentifier(keys keys.Keys) (string, error) {
 	key, err := keys.DeriveKey([]uint32{bip32.FirstHardenedChild + 2})