Add CCEGLView::showCursor bindings#1336
Conversation
|
oh what the hell how did It fail to pass the checks |
|
The class has link on Windows and you've put an address for Windows for the function you added, I don't know if that's related to the issue |
|
The windows function does exist and hooks fine, it's the MacOS builds that are failing. |
|
The issue is that the address in question for Windows I am already assuming already has its symbols included (as is the case with many other functions and classes on libcocos2d.dll) so having the Windows address in the Broma file won't be helpful |
|
You can't hook the function if it doesn't have symbols in broma. I'm made this PR so I could hook this function in one of my mods, as otherwise it did nothing. I tested with and without the broma symbols, and adding the broma symbol made the function hookable. |
|
it's not the matter with the symbol itself, it's with the address you set for Windows, it doesn't need that, practically every other cocos function has been doing fine without a Windows address because the symbols do exist for it already inside libcocos2d.dll, so it's not needed. Intel and M1 Mac addresses are fine, or that actually might be your issue here with failing builds. |
|
Yes it does. I just explained why I need the address. I am, unable to hook the function otherwise. |
|
The issue with the build is in fact, iMac and m1. |
2 participants
Adds bindings for CCEGLView::showCursor on windows and mac