Repository navigation
Refactor Android Rewards actions into the view model - #1541
Merged
Merged
Conversation
Consolidated the Rewards screen's nine callbacks into one RewardsAction. The view model now shows the toast, the error and the points check, as on iOS. Activating a code from the dialog now shows Done.
The create and redeem code sheets no longer pass results back through callbacks. The view model owns which sheet is open, the spinner and the error, as iOS does.
The view model guards and resets the in-flight flag as the security, sign-message and import view models do, and names it like the price alerts refresh flag.
The create and redeem code dialogs were the same text field, Done button and spinner under different titles. iOS draws both with one TextInputScene. Decorative icons no longer carry a text description, and the emoji sizes are named.
gemcoder21
reviewed
Oct 13, 2026
| import uniffi.gemstone.GemRewardsIntroItem | ||
| import uniffi.gemstone.GemRewardsInviteAction | ||
|
|
||
| private val giftEmojiSize = 64.sp |
Contributor
There was a problem hiding this comment.
can we reuse with existing sizes?
gemcoder21
approved these changes
Oct 13, 2026
The gift and intro emojis used their own 64 sp and 26 sp. They now use displayLarge and titleLarge; titleLarge is the 22 sp of the title2 style iOS uses for the same intro emojis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidated the Rewards screen's nine callbacks into one RewardsAction.
The view model now owns the toast, the errors, the points check and the code sheets, as on iOS.
Activating a code from the sheet now shows Done.