Repository navigation
Refactor and fix private key reminder screen - #1537
Merged
Merged
Conversation
1. Private key reminder intro, card titles and descriptions, and the reveal warning in every language 2. Regenerate the iOS catalog and Android resources, with the iOS keys grouped under PrivateKey
1. Core picks the reminder cards for each secret kind: a wallet imported from a private key gets the Secret Phrase reminder's three cards and emoji, worded for the key, instead of the Secret Phrase reminder itself 2. The reveal warns "Do not share your Private Key!" instead of naming the Secret Phrase 3. Both apps keep one reminder screen and pass it the secret kind; Android's reminder uses body-size descriptions and the same card spacing as iOS 4. iOS no longer hyphenates a private key where it wraps 5. Add the rule to the product doc
0xh3rman
force-pushed
the
hm/private-key-reminder
branch
from
October 13, 2026 01:28
06d8e85 to
ffe9a61
Compare
0xh3rman
marked this pull request as ready for review
October 13, 2026 01:33
gemcoder21
reviewed
Oct 13, 2026
1. GemSecurityReminderItem is KeepSafe, DoNotShare and NoRecovery with a kind, instead of separate private key cases 2. Apps pick each card's text by kind and its emoji by card alone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It also closes #1394
Why new strings instead of reusing the Secret Phrase ones with a placeholder
The private key reminder mirrors the Secret Phrase reminder card for card, with its own
private_key_reminder_*strings rather than one shared string with%@for "secret phrase" / "private key":