Repository navigation
Open the asset behind a perpetual market - #1535
Merged
Merged
Conversation
A perpetual market shows the asset it tracks under Info (Bitcoin on BTC, PancakeSwap on BNB Chain on CAKE); tapping it opens the asset screen. The market refresh stores the asset's official association through update_asset, and both apps read it from storage with AssociatedAssetsQuery, so the row shows offline and updates when the refresh saves it.
gemcoder21
reviewed
Oct 12, 2026
| ), | ||
| initialValue: [], | ||
| ) | ||
| associatedAssetsQuery = ObservableQuery( |
Contributor
There was a problem hiding this comment.
seems redundant, you should be able to fetch asset via perpetualQuery?
PerpetualQuery already joins the perpetual's asset, so it reads the official associated assets with it; the separate AssociatedAssetsQuery is gone on both apps.
gemdev111
marked this pull request as ready for review
October 13, 2026 10:20
gemcoder21
approved these changes
Oct 13, 2026
gemcoder21
reviewed
Oct 13, 2026
| } | ||
|
|
||
| #[uniffi::export] | ||
| pub fn perpetual_associated_asset_rows(assets: Vec<Asset>) -> Vec<GemPerpetualAssociatedAssetRow> { |
Contributor
There was a problem hiding this comment.
can we not export perpetual_associated_asset_rows ?
perpetual_associated_asset_rows is no longer exported: details() takes the market's associated assets and returns their rows, like the position row.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A perpetual market now shows the asset it tracks under Info — Bitcoin on the BTC market, PancakeSwap on BNB Chain on CAKE — and tapping it opens that asset's screen to buy, swap or receive it. The link comes from Gem's asset associations, is kept on the device and shows offline. Available on iOS and Android.