Repository navigation
Core: perpetual PnL percent is the return on the opening margin - #1532
Merged
Merged
Conversation
The position row, the position details and the close confirmation divided the PnL by the margin in use, which moves with the PnL, so a gain read smaller and a loss larger than Hyperliquid's ROE and than the percent the user sets in Auto Close. They now divide by the margin the position opened with, its entry value over its leverage. The close confirmation carries the closing position's PnL, entry price and opening margin as one value instead of two optional fields. The Margin rows, the Reduce maximum and the full-close check keep the margin in use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A position's PnL percent did not match Hyperliquid's ROE or the percent the user sets in Auto Close: it was measured against the margin in use, which grows and shrinks with the PnL, so gains read smaller and losses larger. An isolated 5x NEAR position at +13.8% on Hyperliquid showed +12.1% in Gem.
The Positions list, the position details and the close confirmation now measure the PnL against the margin the position opened with. The close confirmation carries the closing position as one value instead of two optional fields. Margin rows and the Reduce and Close amounts are unchanged.