Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

[APTOS] Fix token balances - #217

Merged
furenster merged 2 commits into
mainfrom
aptos/fix_token_balances
Aug 28, 2025
Merged

furenster merged 2 commits into
mainfrom
aptos/fix_token_balances

Conversation

@furenster

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @furenster, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to resolve an issue with how Aptos token balances are retrieved. It refactors the underlying mechanism for fetching balances, moving to a more direct service call for individual tokens. Additionally, it introduces concurrent processing to enhance the efficiency of querying multiple token balances simultaneously.

Highlights

  • Balance Fetching Mechanism Update: The method for fetching Aptos token balances has been updated from querying general resources to directly calling the balance service for each token, providing a more direct and potentially efficient approach.
  • Concurrent Balance Retrieval: Asynchronous operations using Kotlin coroutines (async, awaitAll) have been introduced to fetch multiple token balances concurrently, which is expected to improve performance, especially when dealing with a large number of tokens.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the token balance fetching logic for Aptos. The implementation is changed from a single bulk API call to fetching balances for each token concurrently. While the new implementation seems correct and handles errors for individual tokens gracefully, the associated tests have not been updated and are likely broken. Additionally, a comment explaining the rationale for this significant change in fetching strategy would improve code maintainability.

@furenster
furenster merged commit e991559 into main Aug 28, 2025
1 check passed
@furenster
furenster deleted the aptos/fix_token_balances branch August 28, 2025 15:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant