Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

Fix notificaions - #216

Merged
furenster merged 2 commits into
mainfrom
notifications/fix
Aug 28, 2025
Merged

furenster merged 2 commits into
mainfrom
notifications/fix

Conversation

@furenster

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @furenster, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue with push notifications by correctly integrating Firebase Cloud Messaging (FCM) and ensuring that device push tokens are properly requested, stored, and transmitted. It refactors the RequestPushToken interface and its implementations, enabling proper initialization of Firebase and accurate handling of push token data within the device repository. The changes ensure that the application can reliably send and receive notifications.

Highlights

  • Firebase Integration: The pull request integrates the com.google.gms.google-services Gradle plugin and adds an init method to the RequestPushToken implementation for Firebase Cloud Messaging (FCM), ensuring proper initialization of Firebase services.
  • Push Token Handling Correction: The logic for handling push tokens has been corrected in DeviceRepository.kt, ensuring that the actual push token is now correctly used and transmitted when syncing device information, rather than an empty string.
  • Dependency Injection Refinement: The RequestPushToken dependency is now properly injected into BuildInfo, moving away from direct instantiation and making the module more modular and testable.
  • Interface Standardization: The RequestPushToken interface has been standardized by changing it from a fun interface to a regular interface, adding an init method, and renaming the token request method from invoke to requestToken across all implementations (FCM and stub).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix notifications by integrating Firebase Cloud Messaging. The changes include adding the Google Services plugin, refactoring the push token request logic, and fixing a bug where the device was registered with an empty push token. There is also a typo in the pull request title ('notificaions').

My review has identified a critical issue where Firebase is not initialized, which would likely cause a crash. I've also found a misuse of the suspend keyword on an asynchronous function with a callback, and a few typos in filenames and directory names. Please see the detailed comments for suggestions to address these points.

Comment thread app/src/main/kotlin/com/gemwallet/android/di/BuildInfoModule.kt
Comment thread flavors/fcm/src/main/kotlin/com/gemwallet/android/flavors/RequestrPushToken.kt Outdated
@furenster
furenster merged commit 2b0e16e into main Aug 28, 2025
1 check passed
@furenster
furenster deleted the notifications/fix branch August 28, 2025 10:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant