This repository was archived by the owner on Jun 1, 2026. It is now read-only.
Repository navigation
Cleanup Cetus tx_builder.rs and add tests - #1133
Merged
Merged
Conversation
0xh3rman
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements protobuf varint overflow checks, optimizes byte field encoding, and adds comprehensive tests for SUI RPC message decoding and encoding. It also refactors address handling in the SUI transaction builder to use SuiAddress and standard Rust conversion traits. Review feedback points out a missing FromStr implementation for SuiAddress, identifies inconsistent error handling in address parsing within the swapper crate, and suggests restoring helper functions to improve code modularity and readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.