Skip to content

timelapse.py: sentinel1_timeseries - Stop have a mutable default for orbit. #2620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
schwehr wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

timelapse.py: sentinel1_timeseries - Stop have a mutable default for orbit. #2620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions geemap/timelapse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1487,7 +1487,7 @@ def sentinel1_timeseries(
frequency: str = "year",
clip: bool = False,
band: str = "VV",
orbit: list[str] = ["ascending", "descending"],
orbit: list[str] | None = None,
**kwargs,
) -> ee.ImageCollection:
"""Return a Sentinel 1 ImageCollection of mean composites at a specified frequency.
Expand Down Expand Up @@ -1522,8 +1522,9 @@ def sentinel1_timeseries(
# Load and filter Sentinel-1 collection.
col = ee.ImageCollection("COPERNICUS/S1_GRD").filterBounds(roi)

# Apply orbit filtering.
if orbit:
# Set orbit to {} to not have an orbit.
if orbit or orbit is None:

@naschmitz naschmitz Feb 20, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this changes the behavior. Before, you could not have an orbit by passing in None. That's no longer true here (unless I'm missing something).

orbit = orbit or ["ascending", "descending"]
# Convert orbit strings to uppercase for consistency.
orbit_upper = [o.upper() for o in orbit]
orbit_filter = ee.Filter.inList("orbitProperties_pass", orbit_upper)
Expand Down