Node version update from 22 to 24#2347
Merged
GCHQDeveloper581 merged 13 commits intomasterfrom Apr 28, 2026
Merged
Conversation
Remove stale --experimental-* flags and redundant node version reset step in releases workflow.
- upgraded chromedriver from ^130.0.4 to ^146.0.5 - upgraded cspell from ^8.19.4 to ^9.7.0 - upgraded globals from ^15.15.0 to ^17.4.0 - upgraded sitemap from ^8.0.3 to ^9.0.1 - upgraded otpauth from 9.3.6 to ^9.5.0
Avoids DEP[0040] warnings regarding use of the deprecated node internal punycode module
Closed
C85297
reviewed
Apr 28, 2026
| const buffer = await readFile(urlStr); | ||
| return new Response(buffer, { | ||
| status: 200, | ||
| headers: { "Content-Type": "application/wasm" }, |
Member
There was a problem hiding this comment.
Do we want to hardcode this content type? @GCHQDeveloper581
Contributor
Author
There was a problem hiding this comment.
Might look at this one longer term...
C85297
reviewed
Apr 28, 2026
C85297
approved these changes
Apr 28, 2026
Member
C85297
left a comment
C85297
left a comment
There was a problem hiding this comment.
Approved with optional suggestions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Credit
This PR is almost entirely based on a rebased cherry-pick of commits from #2278 by @lzandman
A new branch/PR was required owing to problems encountered with Jimp and the Webpack 5 updates in the original (which are due to a bug in Jimp).
Description below (edited) from the original PR
Description
Update the Node version from 22 to 24 and also bring in some other related fixes.
.nvmrc,Dockerfile, devcontainer, GitHub Actions workflows)tests/lib/wasmFetchPolyfill.mjs)npm update, includingcore-jsto 3.49.0Existing Issue
#1960
AI disclosure
No AI used in this PR version. Use of AI in original #2278 not known/declared as it predates the question being asked. However all changes have been verified by the author of this PR.
Test Coverage
Mostly uses existing tests as functionality should not have changed. New test added for wasm fetch polyfill.