fix: handle Auto delimiter in fromDecimal (#2217)#2308
Open
OndraDol wants to merge 1 commit intogchq:masterfrom
Open
fix: handle Auto delimiter in fromDecimal (#2217)#2308OndraDol wants to merge 1 commit intogchq:masterfrom
OndraDol wants to merge 1 commit intogchq:masterfrom
Conversation
C85297
requested changes
Apr 7, 2026
Comment on lines
+535
to
+539
| it("From decimal with Auto delimiter", () => { | ||
| assert.strictEqual(chef.fromDecimal("72,101,108,108,111").toString(), "Hello"); | ||
| assert.strictEqual(chef.fromDecimal("72:101:108:108:111").toString(), "Hello"); | ||
| assert.strictEqual(chef.fromDecimal("72;101;108;108;111").toString(), "Hello"); | ||
| }), |
Member
There was a problem hiding this comment.
Would you mind adding a test to check the functionality of handling negative numbers? From reading your code, I believe that the output of chef.fromDecimal("-72 101 108 -108 -111") would be [-72, 101, 108, -108, -111] and it would be good to confirm whether that is or is not the case in a test.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the fromDecimal() function to correctly handle the Auto delimiter mode. Utils.charRep("Auto") returns undefined, causing data.split(undefined) to treat the entire input as a single element and only parse the first decimal value.
Changes
/[^\d-]+/to split on any non-digit, non-minus character when delimiter is "Auto", consistent with how fromHex() handles its Auto modeRelated Issue
Closes #2217
Testing