fix: Gzip comment with header checksum produces corrupt streams#2288
Open
williballenthin wants to merge 1 commit intogchq:masterfrom
Open
fix: Gzip comment with header checksum produces corrupt streams#2288williballenthin wants to merge 1 commit intogchq:masterfrom
williballenthin wants to merge 1 commit intogchq:masterfrom
Conversation
The Gzip operation manually set the FCOMMENT flag bit after zlibjs had already calculated the header CRC16, corrupting the checksum. Fix by setting options.flags.fcomment before calling compress(), letting zlibjs handle the flag internally. Closes gchq#2243
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Gzip operation manually set the FCOMMENT flag bit after zlibjs had already calculated the header CRC16, corrupting the checksum. Fix by setting options.flags.fcomment before calling compress(), letting zlibjs handle the flag internally.
Closes #2243
AI disclosure
Claude Code Opus 4.6