Make compatible with node >=22#2273
Merged
GCHQDeveloper581 merged 8 commits intomasterfrom Apr 28, 2026
Merged
Conversation
This is a breaking change for Node <=16 Therefore minimum requirement and build/edit environment updated to the current Node LTS, v20
Contributor
Author
|
npm install will get a EBADENGINE from @astronautlabs/amf@0.0.6 which has node version pinned to ^14. This restriction has been removed from the (unreleased) HEAD of the corresponding git repository at https://github.com/astronautlabs/amf The warning could be avoided by directly referencing the git commit but whilst I have tested this locally I've not included this change. |
This was referenced Mar 21, 2026
C85297
reviewed
Mar 23, 2026
Contributor
Author
|
@C85297 "yes" to all those comments. Related PR #2278 onto this branch should resolve this. When the original #2130 was written 20.X was still an active branch, and my motivation for using it then was that it (largely) retained backward compatibility with 18. We now need 24.X for actions anyway, and #2278 moves us on to that. |
Closed
C85297
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change for Node <=16
Therefore minimum requirement and build/edit environment have been updated to the current Node LTS, v22
(please also note - there is a further PR #2278 which extends the update to the latest node LTS, v24)
Resolves #1960, #2108
Requires a major version update
Originally presented as #2130 - this is the same code rebased onto master as of 2026-03-23 but now as a branch in the main gchq/CyberChef repository to make it easier for others to contribute improvements.