Uprank {Copy,Extract}SubMatrix methods for compressed matrices#6349
Uprank {Copy,Extract}SubMatrix methods for compressed matrices#6349
Conversation
... so that they are actually used. Also remove redundant `CopySubVector` methods.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6349 +/- ##
=======================================
Coverage 78.62% 78.63%
=======================================
Files 684 684
Lines 292701 292689 -12
Branches 8686 8660 -26
=======================================
+ Hits 230148 230149 +1
+ Misses 60744 60729 -15
- Partials 1809 1811 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ThomasBreuer
left a comment
There was a problem hiding this comment.
Yes, the new generic methods that were introduced in #6329 have a higher rank than the old special methods.
Eventually we should perhaps define Is8BitMatrixRep to imply IsMatrix, such that the installations for the different kinds of matrix objects will be more comparable,
but in another pull request.
(According to the documentation of NewRepresentation, such implications are not intended, but they are used for example for IsPlistMatrixRep which implies IsMatrixObj. Thus perhaps the formulations in the documentation of NewRepresentation should be changed.)
... so that they are actually used.
Also remove redundant
CopySubVectormethods.