Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/cli-plugin/build-parameters-adapter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,11 @@ export function createBuildParametersFromCliOptions(options: Record<string, any>
// ── identity / build settings ─────────────────────────────────────
bp.editorVersion = options.engineVersion || options.editorVersion || options.unityVersion || '';
bp.customImage = options.customImage || '';
bp.unitySerial = options.unitySerial || process.env.UNITY_SERIAL || '';
bp.unityLicensingServer = options.unityLicensingServer || '';
bp.skipActivation = options.skipActivation || 'false';
// Engine-specific licensing fields (unitySerial, unityLicensingServer,
// unityLicensingToolset, skipActivation, ...) are not assigned here.
// They flow opaquely through BuildParameters' index signature when the host
// populates them; orchestrator does not read them.
// See https://github.com/game-ci/orchestrator/issues/25
bp.runnerTempPath = options.runnerTempPath || process.env.RUNNER_TEMP || '';
bp.targetPlatform = options.targetPlatform || 'StandaloneLinux64';
bp.projectPath = options.projectPath || '.';
Expand Down
11 changes: 9 additions & 2 deletions src/cli/__tests__/commands.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,15 @@ describe('CLI commands', () => {
expect(options['chown-files-to']).toBeDefined();

expect(options['provider-strategy']).toBeDefined();
expect(options['skip-activation']).toBeDefined();
expect(options['unity-licensing-server']).toBeDefined();

// Engine-specific licensing flags are intentionally NOT defined on
// orchestrator's build command — orchestrator is engine-agnostic.
// Hosts (unity-builder action, @game-ci/cli) own those flags and pass
// them through to the build container as environment variables.
// See https://github.com/game-ci/orchestrator/issues/25
expect(options['skip-activation']).toBeUndefined();
expect(options['unity-licensing-server']).toBeUndefined();
expect(options['unity-licensing-toolset']).toBeUndefined();
});

it('sets correct default values', () => {
Expand Down
Loading
Loading