Skip to content

feat: locale-aware number formatting in all time stats #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
noisesfromspace wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: locale-aware number formatting in all time stats #342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions client/app/components/AllTimeStats.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import CardHeader from "./primitives/CardHeader";
const getStats = (period: string) =>
apiFetch<Stats>("/apis/web/v1/stats", { period });

const numberFormatter = new Intl.NumberFormat();

export default function AllTimeStats() {
const { isPending, isError, data, error } = useQuery({
queryKey: ["stats", "all_time"],
Expand Down Expand Up @@ -38,21 +40,33 @@ export default function AllTimeStats() {
className={numberClasses}
title={Math.floor(data.minutes_listened / 60) + " hours"}
>
{data.minutes_listened}
{numberFormatter.format(data.minutes_listened)}
</span>{" "}
Minutes
</div>
<div>
<span className={numberClasses}>{data.listen_count}</span> Plays
<span className={numberClasses}>
{numberFormatter.format(data.listen_count)}
</span>{" "}
Plays
</div>
<div>
<span className={numberClasses}>{data.track_count}</span> Tracks
<span className={numberClasses}>
{numberFormatter.format(data.track_count)}
</span>{" "}
Tracks
</div>
<div>
<span className={numberClasses}>{data.album_count}</span> Albums
<span className={numberClasses}>
{numberFormatter.format(data.album_count)}
</span>{" "}
Albums
</div>
<div>
<span className={numberClasses}>{data.artist_count}</span> Artists
<span className={numberClasses}>
{numberFormatter.format(data.artist_count)}
</span>{" "}
Artists
</div>
</div>
<div>
Expand Down