Skip to content

Include listen_type in the coalescing key used during listen submission #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattusifer wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Include listen_type in the coalescing key used during listen submission #219

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9578cd7
Add listen_type to coalescing key
mattusifer Mar 9, 2026
ba1ab62
Fix typo
mattusifer Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions engine/handlers/lbz_submit_listen.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ func LbzSubmitListenHandler(store submitListenHandlerStore, mbzc mbz.MusicBrainz
SkipSaveListen: req.ListenType == ListenTypePlayingNow,
}

_, err, shared := sfGroup.Do(buildCaolescingKey(payload), func() (interface{}, error) {
_, err, shared := sfGroup.Do(buildCoalescingKey(payload, req.ListenType), func() (interface{}, error) {
return 0, catalog.SubmitListen(r.Context(), store, opts)
})
if shared {
Expand Down Expand Up @@ -315,13 +315,6 @@ func doLbzRelay(requestBytes []byte, l *zerolog.Logger) {
}
}

func buildCaolescingKey(p LbzSubmitListenPayload) string {
// the key not including the listen_type introduces the very rare possibility of a playing_now
// request taking precedence over a single, meaning that a listen will not be logged when it
// should, however that would require a playing_now request to fire a few seconds before a 'single'
// of the same track, which should never happen outside of misbehaving clients
//
// this could be fixed by restructuring the database inserts for idempotency, which would
// eliminate the need to coalesce responses, however i'm not gonna do that right now
return fmt.Sprintf("%s:%s:%s", p.TrackMeta.ArtistName, p.TrackMeta.TrackName, p.TrackMeta.ReleaseName)
func buildCoalescingKey(p LbzSubmitListenPayload, listenType LbzListenType) string {
return fmt.Sprintf("%s:%s:%s:%s", listenType, p.TrackMeta.ArtistName, p.TrackMeta.TrackName, p.TrackMeta.ReleaseName)
}