Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/columbo/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ require (
github.com/Microsoft/go-winio v0.6.2 // indirect
github.com/ProtonMail/go-crypto v1.1.6 // indirect
github.com/bahlo/generic-list-go v0.2.0 // indirect
github.com/buger/jsonparser v1.1.1 // indirect
github.com/buger/jsonparser v1.1.2 // indirect

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Commit the checksums for jsonparser v1.1.2 · correctness

When building from a clean checkout, packages/columbo/go.sum still contains only the v1.1.1 checksums (lines 17–18), so Go's default read-only module mode rejects the newly selected dependency with a missing-checksum error. The Dockerfile's initial go mod download does not resolve this: its subsequent COPY packages/columbo/ ./ restores the stale committed go.sum before go run and go build. Commit the v1.1.2 checksums with this bump.

Suggested fix

Run cd packages/columbo && go mod download github.com/buger/jsonparser and commit the resulting go.sum entries for v1.1.2.

Prompt for a coding agent
Update packages/columbo/go.sum alongside the jsonparser version change at packages/columbo/go.mod:26. Run go mod download github.com/buger/jsonparser from packages/columbo and commit the generated v1.1.2 module and go.mod checksums, so builds do not depend on modifying the checksum file first.

github.com/bytedance/gopkg v0.1.3 // indirect
github.com/bytedance/sonic v1.15.0 // indirect
github.com/bytedance/sonic/loader v0.5.0 // indirect
Expand Down
Loading