Skip to content

fix(docs): deploy production to the prod pages branch - #21

Merged
nutgood merged 1 commit into
mainfrom
fix/docs-prod-pages-branch
Oct 21, 2026
Merged

nutgood merged 1 commit into
mainfrom
fix/docs-prod-pages-branch

Conversation

@zackpollard

@zackpollard zackpollard commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

The docs-futo-cloud-prod production branch is prod, so main uploads only reached the main.* preview alias and docs.futo.cloud kept serving the old yucca build.

@futo-kritika

futo-kritika Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Re-runKritika Review

Targets the prod Pages branch for production documentation deployments.

No findings

Confidence 4/5 · medium risk: The claim that the Pages project's production branch is prod rests only on the description. The review read nothing outside the repository and the account shows no check of it, so a mismatch would again leave docs.futo.cloud serving the old build. The rating is medium because the one-line deploy-script change is easy to revert and affects only the docs site.

Approved

Summary

The change aligns the production upload branch with the Pages configuration described in the pull request. It preserves the workflow's main-branch trigger and leaves pull-request preview routing unchanged.

Merge impact

  • .github/workflows/docs.yml selects production on pushes to main, and packages/docs/.mise/tasks/deploy now submits those builds to docs-futo-cloud-prod with --branch=prod. Confirm the Pages project's production branch is prod and the resulting production deployment serves docs.futo.cloud; that project configuration lives outside this repository.
Review context · 0/6 commands
  • Commands run: none

Reviews (1) · Last reviewed commit: "fix(docs): deploy production to the prod..." · openai/gpt-6.1-sol · $0.02

@futo-kritika futo-kritika Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kritika: confidence 4/5 with medium risk at aafb56c.

@zackpollard
zackpollard deployed to docs-preview October 21, 2026 17:40 — with GitHub Actions Active
@github-actions

Copy link
Copy Markdown

@nutgood
nutgood merged commit cae3120 into main Oct 21, 2026
19 checks passed
@nutgood
nutgood deleted the fix/docs-prod-pages-branch branch October 21, 2026 17:47

This branch was successfully deployed

1 active deployment
docs-preview — aafb56cb Deployed Oct 21, 2026 by zackpollard via Deploy #21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants