Skip to content

fix(#990): add critical commit-before-exit rule to skill #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fullsend-ai-coder wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −0
Open

fix(#990): add critical commit-before-exit rule to skill #991

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions skills/code-implementation/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,13 @@ fractions of the budget so they scale to any timeout value):
gitlint validation and commit immediately. A commit that fails gitlint
CI is better than no commit at all.

## Critical rule — commit before exit

**CRITICAL RULE: Your final tool calls before any text response MUST
include `git add` and `git commit`. Working-tree edits are lost when the
sandbox exits. Commit is the single most important step in this
workflow — a disclosed partial commit is always better than no commit.**

## Process

Follow these steps in order. Do not skip steps — with one exception,
Expand Down Expand Up @@ -844,6 +851,10 @@ Read every line. Check for:

If you added more than necessary, revert the extras before staging.

**After verification passes, proceed IMMEDIATELY to Step 10 (Commit).

@fullsend-ai-review fullsend-ai-review Bot Aug 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] scope-overlap-coordination

The triage note on issue #990 warned that the step-transition guard (change #2) overlaps with #821 proposed change #3. The PR author acknowledged this in the body and states the change was scoped to avoid duplication. The two changes address different failure triggers (#821: pre-commit failure causing step-skipping; this PR: model voluntarily stopping after verification), making them complementary. A future merge conflict is possible when #821 lands.

Suggested fix: When #821 is implemented, the implementer should check this section for potential duplication or consolidation. No blocking action needed before merging this PR.

Do not produce any text summary, status update, or final response
before committing your changes. The commit step is not optional.**

### 10. Commit

```bash
Expand Down
Loading