docs(#940): update notify-agent-sync description to manual-only - #942
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
docs(#940): update notify-agent-sync description to manual-only#942fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
PR #936 removed the on.push trigger from notify-agent-sync.yml, making it manual-only (workflow_dispatch). AGENTS.md and README.md still described the workflow as firing on every push to main. Updated AGENTS.md to replace "fires a repository_dispatch event on every push to main" with "can be manually triggered via workflow_dispatch to fire a repository_dispatch event". Updated README.md workflow table to append "(manual trigger only)" to the notify-agent-sync.yml description. Note: pre-commit could not run in sandbox (network restrictions). Post-script runs it authoritatively. Closes #940
|
🤖 Finished Review · ✅ Success · Started 7:29 PM UTC · Completed 7:40 PM UTC Commit: |
ReviewFindingsMedium
Low
|
fullsend-ai-review
Bot
added
the
requires-manual-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notify-agent-sync.ymlas manually triggered viaworkflow_dispatchinstead of firing on every push tomainnotify-agent-sync.ymlis manual trigger onlyContext
PR #936 removed the
on.pushtrigger fromnotify-agent-sync.yml, making the workflow manual-only (workflow_dispatch). The documentation in AGENTS.md and README.md was not updated to reflect this change, leaving stale references to automatic push-based triggering.Testing
notify-agent-sync.yml) contains onlyworkflow_dispatchas its triggeron:blockmake test— all test suites pass (pre-existing failures inpost-retro-test.share unrelated to this change and also fail onmain)Closes #940
Post-script verification
agent/940-docs-manual-sync)d021f80aea083fc3921b662b0b8534ff2433d09a..HEAD)