Skip to content

fix(#924): add revert to allowed gitlint commit types - #926

Open
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/924-add-revert-commit-type
Open

fix(#924): add revert to allowed gitlint commit types#926
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/924-add-revert-commit-type

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Summary

  • Add revert to the allowed commit types in .gitlint ([contrib-title-conventional-commits] section)
  • Add revert to the documented type prefixes in AGENTS.md section 4 ("Commit message format")

Context

PR #923 used a revert(skillsaw): commit type which is valid per the Conventional Commits spec but was rejected by the commit-lint CI job because .gitlint did not include revert in its allowed types list. This was a configuration gap — all other standard Conventional Commits types were already present.

Testing

Verified locally with gitlint:

  • revert(skillsaw): restore skill names now passes the type check (previously failed with CT1)
  • Invalid types like undo(skillsaw): restore skill names still fail as expected
  • All pre-existing repo tests pass (16 pre-existing failures in post-retro-test.sh are unrelated)

Closes #924

Post-script verification

  • Branch is not main/master (agent/924-add-revert-commit-type)
  • Secret scan passed (gitleaks — 7ad7b5000373150ce1bf1a312dd6713045bea8f8..HEAD)
  • PR body secret scan passed (gitleaks — no-git)

The .gitlint config restricted commit types to
feat,fix,refactor,docs,test,chore,ci,perf,build, omitting
the standard Conventional Commits 'revert' type. This caused
CI commit-lint failures for legitimate revert commits (e.g.,
PR #923). Add 'revert' to the types list in .gitlint and
update AGENTS.md section 4 to document it as an allowed
prefix.

Closes #924
@fullsend-ai-coder
fullsend-ai-coder Bot requested a review from a team as a code owner August 21, 2026 15:08
@fullsend-ai-review

fullsend-ai-review Bot commented Aug 21, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 3:09 PM UTC · Completed 3:20 PM UTC

Commit: 6b6f8f9 · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

Medium

  • [protected-path] AGENTS.md:40 — AGENTS.md is a protected governance file. This PR modifies it to add revert to the documented commit type prefixes (section 4, "Commit message format"). The change is linked to issue Add 'revert' to .gitlint allowed commit types and AGENTS.md #924 and the rationale is clearly explained. Human approval is always required for protected-path changes, regardless of context.

@fullsend-ai-review fullsend-ai-review Bot added the requires-manual-review Review requires human judgment label Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review requires-manual-review Review requires human judgment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add 'revert' to .gitlint allowed commit types and AGENTS.md

0 participants