Skip to content

fix(#1062): reference TARGET_REPO_DIR instead of undefined REPO_DIR #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralphbean merged 5 commits into from
Aug 27, 2026
+6 −6
Merged

fix(#1062): reference TARGET_REPO_DIR instead of undefined REPO_DIR #1063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2757bd4
test: temporary workflow to verify label re-add refires labeled event
ggallen Jul 28, 2026
65b8279
test: switch to pull_request trigger since issues are disabled on thi…
ggallen Jul 28, 2026
687f17e
Revert "test: switch to pull_request trigger since issues are disable…
ggallen Jul 28, 2026
0e44e80
test: remove temporary label-refire experiment workflow
ggallen Jul 28, 2026
15405a1
fix(#1062): reference TARGET_REPO_DIR instead of undefined REPO_DIR
ggallen Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions eval/scripts/run-fullsend.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ FIXTURE_TYPE="${FIXTURE_TYPE:?FIXTURE_TYPE is required (set by before_each hook)
# The hook already created it and pushed content.
#
# Layout mirrors GHA for code/fix: harness expands
# REPO_DIR=${GITHUB_WORKSPACE}/target-repo for post-scripts.
# TARGET_REPO_DIR=${GITHUB_WORKSPACE}/target-repo for post-scripts.
EPHEMERAL_REPO="${EPHEMERAL_REPO:?EPHEMERAL_REPO is required}"
FIXTURE_NUMBER="${FIXTURE_NUMBER:?FIXTURE_NUMBER is required (set by before_each hook)}"

Expand Down Expand Up @@ -157,16 +157,16 @@ install -m 0600 /dev/null "$ENV_FILE"

# Code/fix harness env.runner refs — mint normally sets these; eval skips mint.
# Only override GITHUB_WORKSPACE for agents whose post-scripts expand
# REPO_DIR=${GITHUB_WORKSPACE}/target-repo (triage reads config.yaml from
# the real Actions workspace and must not be redirected to the temp clone).
# TARGET_REPO_DIR=${GITHUB_WORKSPACE}/target-repo (triage reads config.yaml
# from the real Actions workspace and must not be redirected to the temp clone).
case "$AGENT" in
code|fix)
emit_env "PUSH_TOKEN_SOURCE" "eval"
# Empty matches production reusable-code.yml: post-code.sh treats unset/empty
# as fallback to the repo default branch (not "allow all"; use * for any).
emit_env "CODE_ALLOWED_TARGET_BRANCHES" ""
emit_env "GITHUB_WORKSPACE" "${EVAL_GH_WORKSPACE}"
emit_env "REPO_DIR" "${TARGET_DIR}"
emit_env "TARGET_REPO_DIR" "${TARGET_DIR}"
Comment thread
ralphbean marked this conversation as resolved.
emit_env "GIT_BOT_EMAIL" "fullsend-eval[bot]@users.noreply.github.com"
;;
esac
Expand Down
2 changes: 1 addition & 1 deletion harness/code.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ validation_loop:
env:
runner:
CODE_ALLOWED_TARGET_BRANCHES: "${CODE_ALLOWED_TARGET_BRANCHES}"
TARGET_REPO_DIR: "${REPO_DIR}"
TARGET_REPO_DIR: "${TARGET_REPO_DIR}"
PUSH_TOKEN: "${PUSH_TOKEN}"
PUSH_TOKEN_SOURCE: "${PUSH_TOKEN_SOURCE}"
REPO_FULL_NAME: "${REPO_FULL_NAME}"
Expand Down
2 changes: 1 addition & 1 deletion harness/fix.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ skills:
env:
runner:
TARGET_BRANCH: "${TARGET_BRANCH}"
TARGET_REPO_DIR: "${REPO_DIR}"
TARGET_REPO_DIR: "${TARGET_REPO_DIR}"
TRIGGER_SOURCE: "${TRIGGER_SOURCE}"
HUMAN_INSTRUCTION: "${HUMAN_INSTRUCTION}"
FIX_ITERATION: "${FIX_ITERATION}"
Expand Down
Loading