Skip to content

build(ci): run the docs-integrity gate on Node 24 - #80

Merged
bketelsen merged 1 commit into
mainfrom
deps/node-24-docs-gate
Aug 30, 2026
Merged

build(ci): run the docs-integrity gate on Node 24#80
bketelsen merged 1 commit into
mainfrom
deps/node-24-docs-gate

Conversation

@bketelsen

Copy link
Copy Markdown
Contributor

Summary

The docs-gate job in .github/workflows/ci.yml still provisioned Node 20,
which reached end-of-life on 2026-04-30. This moves it to Node 24, the
current Active LTS, and updates the two places that state the Node minimum
so the docs no longer disagree with CI.

Exactly three lines change:

  1. .github/workflows/ci.yml:242node-version: "20" -> "24". The
    actions/setup-node SHA pin (820762786026740c76f36085b0efc47a31fe5020,
    v7.0.0) is unchanged, and no other job or workflow line is touched.
  2. AGENTS.md:58 — the tooling bullet now reads Node 24+, noting the 20.x
    end-of-life date and that 24 is the Active LTS.
  3. scripts/check-docs.mjs:6 — header comment Node >= 20 -> Node >= 24.

No script logic, .coverage-thresholds.json value, threshold, Makefile
recipe, or gate is changed or weakened, and no npm ecosystem was added to
.github/dependabot.yml.

Next target: Node 26 becomes Active LTS on 2026-10-28. A reviewer who
would rather wait and jump straight to 26 can close this — 24 is simply the
LTS that is current today.

Checks

  • make check — gofmt leaves no diff, golangci-lint run
    (.golangci.yml) clean, go test -v ./... green (unit + tests/e2e)
  • go test -race -short ./... green
  • go.mod still declares no dependencies (stdlib only)
  • New or changed behavior has focused tests, including failure paths;
    exact output changes update docs/specs/reporter-package.md
    — n/a, no Go behavior changes

Docs housekeeping

  • AGENTS.md, docs/design/overview.md, docs/specs/* updated for
    behavior or convention changes — AGENTS.md tooling bullet
  • Conformance aliases (ADR-0001) untouched — canonical targets edited
    instead

Protected boundaries

  • Changes under .github/workflows/** are called out above as high
    risk. This is a supply-chain change: it raises the runner's Node
    major only. No action is added, no SHA pin is altered, and job
    permissions: stay contents: read.

Verification

node --version on this branch

v24.19.0

node scripts/check-docs.mjs

ok   docs_index_coverage: 1.000 (required 1)
ok   link_integrity: 1.000 (required 1)
ok   symlink_resolution: 1.000 (required 1)
checked: 12 docs, 153 links, 9 symlinks
exit=0

make verify

==> verify: go.mod is tidy
go mod tidy -diff
==> verify: gofmt
==> verify: golangci-lint 2.13.1 (built with go >= 1.26.7)
0 issues.
0 issues.
go vet ./...
go vet ./_examples/deploy ./_examples/fileprocess ./_examples/healthcheck ./_examples/migration 
==> verify: tests
go test ./...
ok  	github.com/frostyard/std/reporter	0.002s
ok  	github.com/frostyard/std/tests/e2e	3.043s
exit=0

No Node 20 references remain

$ grep -rn 'Node 20\|node-version\|Node >= 20' --include='*.md' --include='*.yml' --include='*.mjs' .
.github/workflows/ci.yml:242:          node-version: "24"

Node 20 reached end-of-life on 2026-04-30; 24 is the Active LTS. Bump the
docs-gate job's node-version and the two places that state the Node
minimum. The actions/setup-node SHA pin (v7.0.0) is unchanged, as is the
script's logic and every other job.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@bketelsen
bketelsen marked this pull request as ready for review August 30, 2026 07:49
@bketelsen
bketelsen added this pull request to the merge queue Aug 30, 2026
Merged via the queue into main with commit d0f8681 Aug 30, 2026
8 checks passed
@bketelsen
bketelsen deleted the deps/node-24-docs-gate branch August 30, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant