docs(specs): correct reviewer gate in PR rubric - #76
Merged
Conversation
Clarify that reviewers should run make verify, not make check, and describe the real differences between the two targets without mirroring CI job details.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bketelsen
marked this pull request as draft
August 28, 2026 19:25
bketelsen
marked this pull request as ready for review
August 28, 2026 19:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- replace the rubric's reviewer gate from mutating
make checkto non-mutatingmake verify\n- describe the actualmake verifysteps and the relevant divergences from author-sidemake check\n- keep the Race Detection sentence unchanged while pointing readers to.github/workflows/ci.ymlfor CI reference\n\nCloses #74\n\n## Verification\n-make verifypasses on this branch\n-git status --porcelainis empty aftermake verify\n-mise exec node@20.20.2 -- node scripts/check-docs.mjspasses\n-grep -n 'gofmt -w' docs/specs/pr-review-rubric.mdonly matches a line that explicitly saysmake checkrewrites files\n-git diff main --name-onlyshows onlydocs/specs/pr-review-rubric.md\n