fix(reporter): make TextReporter fail-stop after a writer error - #69
Open
bketelsen wants to merge 1 commit into
Open
fix(reporter): make TextReporter fail-stop after a writer error#69bketelsen wants to merge 1 commit into
bketelsen wants to merge 1 commit into
Conversation
Latch internal failure state on the first io.Writer error (or short write) and make every later reporting call a silent no-op, matching JSONReporter's existing transport-failure handling, so a partial or failed text stream can never be followed by valid-looking output. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
bketelsen
marked this pull request as ready for review
August 25, 2026 00:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TextReporternow latches internal failure state on the firstio.Writererror (or short write) and makes every later reporting call a silent no-op, matchingJSONReporter's existing writer-failure handling, so a partial or failed text stream can never be followed by valid-looking output.writehelper; each method builds its full formatted output and sends it in one call.docs/specs/reporter-package.mdanddocs/design/overview.mdnow describeTextReporter's writer-failure behavior as silent and fail-stop.Test plan
reporter/text_test.go: newTestTextReporter_LatchesAfterWriterErroruses a writer that partially writes then errors, and proves a later reporting call does not invoke the writer again or append output.TextReporteroutput, nil-writer,JSONReporter, andNoopReportertests pass unchanged.make checknode scripts/check-docs.mjs🤖 Generated with Claude Code