fix(compiler): evaluate const increment RHS and recheck global for-limits - #1220
fix(compiler): evaluate const increment RHS and recheck global for-limits#1220frostney wants to merge 1 commit into
Conversation
…mits Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe compiler now excludes const locals from numeric self-increment optimization and global-backed variables from counted-loop limit snapshots. Compiler and language tests cover const errors, mutable locals, dynamic limits, and retained increment optimization. ChangesCompiler optimization guards
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The changes are narrowly scoped to compiler evaluation and counted-for limit behavior, with the reported test and formatting checks passing; no actionable merge-blocking risk remains beyond normal review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. (5 skipped: 5 unsupported.) Full details: Description checkExplanation The description follows the repository template. It explains the changes, constraints, non-goals, related PR, and testing results. The optional benchmark item is unchecked, but this does not prevent a pass. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
Web Tooling Benchmark
18 pinned Web Tooling workloads; 18 workloads produced at least one Goccia sample. Raw results from 1 sample per workload; full stdout/stderr for failures and min/max/CV stay in the |
Benchmark Results440 benchmarks · PR vs same-runner Interpreted: 🟢 33 improved · 🔴 15 regressed · 392 unchanged · avg +1.9% Typical per-run noise (median variance): interpreted ±2.2%, bytecode ±1.9%. Deltas within noise overlap and read as unchanged. arraybuffer.js — Interp: 🟢 1, 13 unch. · avg +1.2% · Bytecode: 🟢 1, 13 unch. · avg +0.8%
arrays.js — Interp: 🟢 1, 18 unch. · avg +1.1% · Bytecode: 🟢 3, 16 unch. · avg +0.1%
async-await.js — Interp: 6 unch. · avg +1.1% · Bytecode: 6 unch. · avg -3.3%
async-generators.js — Interp: 2 unch. · avg +3.9% · Bytecode: 2 unch. · avg +1.2%
atomics.js — Interp: 🟢 1, 5 unch. · avg +2.1% · Bytecode: 🟢 1, 🔴 1, 4 unch. · avg -0.6%
base64.js — Interp: 🟢 1, 9 unch. · avg -0.9% · Bytecode: 🟢 2, 🔴 1, 7 unch. · avg -0.5%
classes.js — Interp: 🟢 1, 30 unch. · avg +1.2% · Bytecode: 🟢 1, 🔴 1, 29 unch. · avg -0.5%
closures.js — Interp: 11 unch. · avg +2.1% · Bytecode: 11 unch. · avg +0.1%
collections.js — Interp: 12 unch. · avg +1.2% · Bytecode: 🟢 1, 11 unch. · avg +0.2%
csv.js — Interp: 13 unch. · avg +0.2% · Bytecode: 🔴 2, 11 unch. · avg +1.3%
destructuring.js — Interp: 🟢 2, 🔴 1, 19 unch. · avg +1.7% · Bytecode: 🟢 2, 🔴 1, 19 unch. · avg +0.5%
fibonacci.js — Interp: 🔴 2, 6 unch. · avg -2.2% · Bytecode: 🔴 1, 7 unch. · avg -3.7%
float16array.js — Interp: 🔴 1, 31 unch. · avg -0.3% · Bytecode: 🔴 2, 30 unch. · avg -0.7%
for-in/for-in.js — Interp: 3 unch. · avg -0.2% · Bytecode: 3 unch. · avg -3.0%
for-of.js — Interp: 🔴 1, 6 unch. · avg +1.6% · Bytecode: 7 unch. · avg +1.4%
generators.js — Interp: 4 unch. · avg -0.4% · Bytecode: 🟢 2, 2 unch. · avg +3.6%
intl.js — Interp: 6 unch. · avg -0.1% · Bytecode: 6 unch. · avg -1.5%
iterators.js — Interp: 🟢 5, 37 unch. · avg +2.6% · Bytecode: 🟢 3, 🔴 3, 36 unch. · avg +0.3%
json.js — Interp: 🟢 1, 🔴 1, 21 unch. · avg -1.1% · Bytecode: 🟢 5, 18 unch. · avg +3.6%
jsx.jsx — Interp: 🟢 1, 20 unch. · avg +0.5% · Bytecode: 🔴 9, 12 unch. · avg -6.0%
modules.js — Interp: 9 unch. · avg +0.8% · Bytecode: 9 unch. · avg -2.4%
numbers.js — Interp: 12 unch. · avg +0.3% · Bytecode: 🟢 2, 10 unch. · avg +2.2%
objects.js — Interp: 8 unch. · avg +3.2% · Bytecode: 8 unch. · avg -2.9%
promises.js — Interp: 12 unch. · avg -1.0% · Bytecode: 🔴 5, 7 unch. · avg -5.1%
property-access.js — Interp: 5 unch. · avg +1.4% · Bytecode: 5 unch. · avg -0.7%
regexp.js — Interp: 13 unch. · avg +0.5% · Bytecode: 🟢 3, 10 unch. · avg +1.7%
strings.js — Interp: 19 unch. · avg +0.3% · Bytecode: 🟢 1, 18 unch. · avg +1.9%
temporal.js — Interp: 6 unch. · avg -2.2% · Bytecode: 6 unch. · avg -2.8%
tsv.js — Interp: 9 unch. · avg -0.9% · Bytecode: 🔴 1, 8 unch. · avg -0.6%
typed-arrays.js — Interp: 🟢 11, 🔴 1, 10 unch. · avg +17.1% · Bytecode: 🟢 4, 🔴 10, 8 unch. · avg +11.5%
uint8array-encoding.js — Interp: 🟢 2, 🔴 6, 10 unch. · avg -0.3% · Bytecode: 🟢 5, 🔴 4, 9 unch. · avg -8.2%
weak-collections.js — Interp: 🟢 6, 🔴 2, 7 unch. · avg +14.3% · Bytecode: 🟢 2, 🔴 3, 10 unch. · avg +0.5%
Deterministic profile diffDeterministic profile diff: no significant changes. Measured on ubuntu-latest x64. Each PR run also builds the |
Suite TimingTest Runner (interpreted: 12,818 passed; bytecode: 12,818 passed)
MemoryGC rows aggregate the main thread plus all worker thread-local GCs. Test runner worker shutdown frees thread-local heaps in bulk; that shutdown reclamation is not counted as GC collections or collected objects.
Benchmarks (interpreted: 440; bytecode: 440)
MemoryGC rows aggregate the main thread plus all worker thread-local GCs. Benchmark runner performs explicit between-file collections, so collection and collected-object counts can be much higher than the test runner.
Boot
Empty-script ( Measured on ubuntu-latest x64. |
JetStream 3 Performance Barometer
Geomean reference ratio: QuickJS 25.53×; Node.js 295.79×. 1.00× means aligned; values above 1.00× mean Goccia was proportionally slower after normalizing JetStream’s higher-is-better score. This is a directional barometer across runtimes with different goals, not a product ranking. Raw samples and failure details remain in the |
test262 Conformance
Areas closest to 100%
Per-test deltas (+0 / -0 / timeout +0 / -1)Resolved timeouts (1):
Steady-state failures and timeouts are non-blocking; PASS → non-timeout failure transitions fail the conformance gate. Measured on ubuntu-latest x64, bytecode mode. Areas grouped by the first two test262 path components; minimum 25 attempted tests, areas already at 100% excluded. Δ vs main compares against the most recent cached |
AWFY Results
Geomean Ratios
14 pinned AWFY benchmarks. Medians from 5 interleaved samples per engine; raw JSON includes min/max/CV and is attached as the |
Summary
#1215←#1216←#1217←#1219←#1220..agent/HANDOFF.md(OP_ADD_INTvsOP_SUB_INT) and adds a Use-when clause for the optimize-runtime skill.OP_SET_LOCALin the hand-assembledGET_LOCAL_PROP_CONSTVM test (GetLocalRegisteralready falls back to registers).Testing
Local gates on
604f0ad7:./format.pas --check;./build.pas testrunner;./build/GocciaTestRunner testsand--mode=bytecode(1615 files, 12818 tests, 0 failed each);./build/Goccia.Compiler.Test(59/59).