Skip to content

V3.2.3 PR Fixes#436

Merged
kapil2704 merged 2 commits intofroala:v3.2.3from
paresh-accolite:v3.2.3-PrFixes
Sep 30, 2020
Merged

V3.2.3 PR Fixes#436
kapil2704 merged 2 commits intofroala:v3.2.3from
paresh-accolite:v3.2.3-PrFixes

Conversation

@paresh-accolite
Copy link
Copy Markdown

@kapil2704
Copy link
Copy Markdown
Contributor

This needs testing before merge as we are using Lodash as some places & some of the functions may hamper previously encountered issue of 'events'. So will review & update this soon.

@kapil2704
Copy link
Copy Markdown
Contributor

I can observe that 'initialized' event is not working this PR, so im not merging this.

Here is the screenshot from Master branch
Screenshot from 2020-09-30 10-55-17

Here is the scrrenshot from this PR
Screenshot from 2020-09-30 10-54-23

public titleOptions: Object = {
placeholderText: 'Edit Your Content Here!',
charCounterCount: false,
// toolbarInline: true,
events: {
"initialized": () => {
console.log('initialized');
},
"contentChanged": () => {
console.log("content changed");
},
"focus": () => {
console.log('focus')
},
"blur": () => {
console.log('blur')
}
}
}

@paresh-accolite
Copy link
Copy Markdown
Author

@kapil2704 yes i have found the issue , it was regarding registration of initialize event , I have fixed it .

Please find the working sample :

iangular

@kapil2704
Copy link
Copy Markdown
Contributor

Thanks @paresh-accolite Working fine now, im merging this.

@kapil2704 kapil2704 merged commit 48d13a5 into froala:v3.2.3 Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants