macOS cache#770
Open
pgilfernandez wants to merge 3 commits into
Open
Conversation
Member
|
Thanks, will do a review when I get the time (sometime this week). |
Member
|
Did a quick test of d076942, and it "fixes" the main cache issue on macOS, but it's still a weird one and I still don't know the rot of the issue, anyway a good workaround 👍 I think we just run Will check the rest later. |
Author
|
it sounds great! |
Member
|
I cherry-picked d076942 to |
Member
|
I took two changes from videoencoder.cpp into this 13b5c1b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @rodlie,
I've been trying to improve the experience of working with video within Friction under macOS. I used IA to see if it could do it and, after some tests I think it got better.
Have a look at the code and get the ideas, it may have fixed/improved some issues:
I hope it helps☺️