fix: handle first-time item insertion during comparison - #368
Open
rahul-arb wants to merge 1 commit into
Open
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
Confidence Score: 5/5This looks safe to merge.
|
| Filename | Overview |
|---|---|
| webshop/webshop/crud_events/item/update_website_item.py | Adds a defensive return before comparing editable Item fields when no previous document is available. |
Reviews (1): Last reviewed commit: "fix: handle first-time item insertion du..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where the website item update logic fails for newly created Items because it attempts to compare the current document with a previous version that does not exist.
Root Cause
During the initial insert, there is no previous document available. The existing comparison logic assumes one exists, resulting in an exception.
Solution
Testing
Fixes issue Issue no 367