Skip to content

Modernize Webshop: checkout UI, Raast QR integration, and performance… - #360

Open
maxfu9 wants to merge 17 commits into
frappe:developfrom
maxfu9:develop
Open

Modernize Webshop: checkout UI, Raast QR integration, and performance…#360
maxfu9 wants to merge 17 commits into
frappe:developfrom
maxfu9:develop

Conversation

@maxfu9

@maxfu9 maxfu9 commented Apr 12, 2026

Copy link
Copy Markdown

… optimizations

@mergify

mergify Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@greptile-apps

greptile-apps Bot commented Jul 2, 2026

Copy link
Copy Markdown

Confidence Score: 2/5

Not safe to merge without addressing the wishlist-injection vector and the other logic defects found across the new code.

An unauthenticated guest can overwrite any existing user's wishlist by submitting their email to convert_guest_cart_to_customer. Additionally, get_item_review_summary fetches all reviews for an item with no limit and is called once per item in every storefront listing request; abandoned_cart_reminder_count is always reset to 1 rather than incremented; and og:site_name is hardcoded to "Euro Plast", breaking portability for any other installation.

webshop/webshop/shopping_cart/cart.py (guest cart conversion and wishlist migration), webshop/webshop/api.py (review summary N+1 and unbounded query), webshop/webshop/engagement.py (reminder counter logic), webshop/webshop/doctype/website_item/website_item.py (hardcoded site name and duplicate imports)

Reviews (11): Last reviewed commit: "Hide Raast QR exception details" | Re-trigger Greptile

Comment thread webshop/www/checkout-success.py Outdated
Comment thread webshop/webshop/api.py
Comment thread webshop/webshop/shopping_cart/cart.py Outdated
Comment thread webshop/webshop/shopping_cart/product_info.py
Comment thread webshop/webshop/shopping_cart/product_info.py
Comment thread webshop/webshop/api.py
Comment thread webshop/webshop/api.py
Comment thread webshop/webshop/shopping_cart/cart.py
Comment thread webshop/webshop/shopping_cart/cart.py
Comment thread webshop/webshop/api.py
@greptile-apps

greptile-apps Bot commented Jul 2, 2026

Copy link
Copy Markdown

Want your agent to iterate on Greptile's feedback? Try greploops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant