Skip to content

fix(marketplace-add-version): Handle more than one app source#6120

Merged
regdocs merged 4 commits intodevelopfrom
marketplace-version-fix
Apr 20, 2026
Merged

fix(marketplace-add-version): Handle more than one app source#6120
regdocs merged 4 commits intodevelopfrom
marketplace-version-fix

Conversation

@regdocs
Copy link
Copy Markdown
Member

@regdocs regdocs commented Apr 15, 2026

When fetching branches from app sources for a marketplace app version, we're picking the top 1 result which may not always be the intended branch. Fixed this by getting all branches from all app sources created by the team in the past for that app.

ref: https://support.frappe.io/helpdesk/tickets/65418

When fetching branches from app sources for a marketplace app, we're picking the top 1 result which may not always be the intended branch. Fixed this by getting all branches from all app sources created by the team in the past for that app.
Comment thread press/api/marketplace.py Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

❌ Patch coverage is 84.84848% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.09%. Comparing base (f4234a2) to head (a248ce8).
⚠️ Report is 763 commits behind head on develop.

Files with missing lines Patch % Lines
press/api/marketplace.py 44.44% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6120       +/-   ##
============================================
- Coverage    90.97%   56.09%   -34.89%     
============================================
  Files          111      911      +800     
  Lines        17629    75904    +58275     
  Branches       516      515        -1     
============================================
+ Hits         16038    42575    +26537     
- Misses        1565    33302    +31737     
- Partials        26       27        +1     
Flag Coverage Δ
dashboard 90.95% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@regdocs regdocs merged commit e90fdca into develop Apr 20, 2026
14 of 15 checks passed
@regdocs regdocs deleted the marketplace-version-fix branch April 20, 2026 10:15
@frappe-pr-bot
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 0.20.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants