fix(marketplace-add-version): Handle more than one app source#6120
Merged
fix(marketplace-add-version): Handle more than one app source#6120
Conversation
When fetching branches from app sources for a marketplace app, we're picking the top 1 result which may not always be the intended branch. Fixed this by getting all branches from all app sources created by the team in the past for that app.
prathameshkurunkar7
requested changes
Apr 16, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6120 +/- ##
============================================
- Coverage 90.97% 56.09% -34.89%
============================================
Files 111 911 +800
Lines 17629 75904 +58275
Branches 516 515 -1
============================================
+ Hits 16038 42575 +26537
- Misses 1565 33302 +31737
- Partials 26 27 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
prathameshkurunkar7
approved these changes
Apr 20, 2026
Collaborator
|
🎉 This PR is included in version 0.20.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When fetching branches from app sources for a marketplace app version, we're picking the top 1 result which may not always be the intended branch. Fixed this by getting all branches from all app sources created by the team in the past for that app.
ref: https://support.frappe.io/helpdesk/tickets/65418