Skip to content

fix(site): Dont add subscription if site creation is broken#6108

Open
Bowrna wants to merge 3 commits intofrappe:developfrom
Bowrna:site_broken_dont_bill
Open

fix(site): Dont add subscription if site creation is broken#6108
Bowrna wants to merge 3 commits intofrappe:developfrom
Bowrna:site_broken_dont_bill

Conversation

@Bowrna
Copy link
Copy Markdown
Contributor

@Bowrna Bowrna commented Apr 14, 2026

fixes: #6110
If the site is broken during creation we should not enable subscription for that case and charge customers.

Reference ticket id: 65320

@Bowrna Bowrna marked this pull request as ready for review April 15, 2026 05:27
@Bowrna
Copy link
Copy Markdown
Contributor Author

Bowrna commented Apr 15, 2026

@shadrak98 let me know if you think this will work out for the case where site creation is broken.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.91%. Comparing base (1e89337) to head (81abea5).
⚠️ Report is 55 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6108       +/-   ##
============================================
- Coverage    73.08%   51.91%   -21.17%     
============================================
  Files          111      909      +798     
  Lines        17631    75806    +58175     
  Branches       272      272               
============================================
+ Hits         12885    39358    +26473     
- Misses        4723    36425    +31702     
  Partials        23       23               
Flag Coverage Δ
dashboard 73.08% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't create Subscription if Site creation fails

1 participant