Skip to content

feat(bench): Use bench_config for worker limits on dedicated servers#6045

Open
kehwar wants to merge 3 commits intofrappe:developfrom
kehwar:bench-config-worker-limits
Open

feat(bench): Use bench_config for worker limits on dedicated servers#6045
kehwar wants to merge 3 commits intofrappe:developfrom
kehwar:bench-config-worker-limits

Conversation

@kehwar
Copy link
Copy Markdown
Contributor

@kehwar kehwar commented Apr 7, 2026

Partial fix for: #2002

@kehwar kehwar requested a review from Aradhya-Tripathi as a code owner April 7, 2026 15:46
@kehwar kehwar changed the title feature: use bench_config for worker limits on dedicated servers feat(bench): use bench_config for worker limits on dedicated servers Apr 7, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 8, 2026

Codecov Report

❌ Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 55.94%. Comparing base (bd280b0) to head (79d7b8f).
⚠️ Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
press/press/doctype/bench/test_bench.py 95.45% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6045       +/-   ##
============================================
- Coverage    90.75%   55.94%   -34.82%     
============================================
  Files          109      910      +801     
  Lines        17369    75776    +58407     
  Branches       525      524        -1     
============================================
+ Hits         15763    42390    +26627     
- Misses        1578    33358    +31780     
  Partials        28       28               
Flag Coverage Δ
dashboard 90.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kehwar kehwar force-pushed the bench-config-worker-limits branch from 355af09 to 79b5d95 Compare April 23, 2026 13:28
@kehwar kehwar changed the title feat(bench): use bench_config for worker limits on dedicated servers feat(bench): Use bench_config for worker limits on dedicated servers Apr 23, 2026
scale_workers still uses release group settings, max_* keys are ignored in bench config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant