Repository navigation
Conversation
Signed-off-by: MrCroxx <mrcroxx.cs@gmail.com>
Codecov Report❌ Patch coverage is
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hybrid lookup durations previously ended when the caller polled the result, so application backpressure inflated hit/miss/error latency. Memory hits consumed through
try_unwrap()skipped these metrics entirely.Record synchronous memory hits immediately and asynchronous results before notifying each waiter. Each coalesced request retains its own start time and completion observer, including requests whose futures are dropped. Preserve existing metric names, hit/miss classification, and memory-hit histograms. Observers also cover concurrent insertion and task cancellation, and execute outside shard and inflight locks. The memory-hit path does not allocate a boxed observer.
Add six regression tests covering result consumption, coalesced fetches, dropped futures, disk hits, misses/errors, concurrent insertion, and cancellation. Document that lookup metrics describe completed requests independently of whether their results are consumed.
Validation:
cargo test -p foyer -p foyer-memory --lib— 58 passed.cargo test -p foyer -p foyer-memory --lib --features tracing— 58 passed.cargo clippy -p foyer -p foyer-memory --all-targets --features tracing -- -D warningscargo fmt --all --checkcargo +nightly fmt --all --check -- --config-path rustfmt.nightly.tomlFixes #1370.