Repository navigation
fix: use try_update and bump MSRV to Rust 1.95 - #1369
Merged
Merged
Conversation
Rust 1.99 deprecates Atomic::fetch_update as a rename of try_update, which is still unstable on MSRV 1.91. Signed-off-by: Xuanwo <github@xuanwo.io>
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Rust 1.99 deprecates fetch_update, and try_update is unstable on MSRV 1.91. Frequency caps and the queue quota keep their previous value, saturation, and limit checks with compare_exchange_weak. Signed-off-by: Xuanwo <github@xuanwo.io>
Xuanwo
changed the title
Xuanwo
marked this pull request as ready for review
October 2, 2026 11:09
MrCroxx
reviewed
Oct 8, 2026
MrCroxx
left a comment
MrCroxx
left a comment
Member
There was a problem hiding this comment.
The API is renamed to try_update, can we directly switch to the new API?
Signed-off-by: Xuanwo <github@xuanwo.io>
Xuanwo
changed the title
MrCroxx
enabled auto-merge (squash)
October 8, 2026 07:01
MrCroxx
disabled auto-merge
October 8, 2026 07:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust 1.99 deprecates
Atomic*::fetch_update, causing CI checks with-D warningsto fail. Use the renamedtry_updateAPI at all four call sites, preserving the existing closures and memory orderings.Raise the minimum supported Rust version to 1.95.0, where
try_updatebecame stable, and align the CI matrix, release toolchain, development commands, and documented MSRV.Validation has not been rerun for this revision.