Skip to content

fix: fix touch() API entry leaking - #1292

Merged
MrCroxx merged 4 commits into
mainfrom
xx/fix-1284
Oct 9, 2026
Merged

MrCroxx merged 4 commits into
mainfrom
xx/fix-1284

Conversation

@MrCroxx

@MrCroxx MrCroxx commented May 18, 2026

Copy link
Copy Markdown
Member

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

Fix #1284

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed cargo x (or cargo x --fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

fix #1284

Signed-off-by: MrCroxx <mrcroxx.cs@gmail.com>
@MrCroxx MrCroxx added this to the v0.22 milestone May 18, 2026
@MrCroxx
MrCroxx requested a review from tisonkun May 18, 2026 06:08
@MrCroxx MrCroxx self-assigned this May 18, 2026
@MrCroxx MrCroxx added the bug Something isn't working label May 18, 2026
@MrCroxx
MrCroxx enabled auto-merge (squash) May 18, 2026 06:09
@codecov

codecov Bot commented May 18, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
foyer-memory/src/raw.rs 92.06% <100.00%> (+1.45%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MrCroxx
MrCroxx merged commit 0fb7628 into main Oct 9, 2026
45 checks passed
@MrCroxx
MrCroxx deleted the xx/fix-1284 branch October 9, 2026 04:16
@yihong0618

Copy link
Copy Markdown
Contributor

wow the fix is so simple

@MrCroxx

MrCroxx commented Oct 9, 2026

Copy link
Copy Markdown
Member Author

wow the fix is so simple

Forgot to align to the new implementation. 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

bug: touch() appears to leak refs

3 participants