fix(LicenseDB): correct UUID nil checks, OIDC base64url decoding, sim…#216
Open
shaheemazmalmmd wants to merge 1 commit into
Open
fix(LicenseDB): correct UUID nil checks, OIDC base64url decoding, sim…#216shaheemazmalmmd wants to merge 1 commit into
shaheemazmalmmd wants to merge 1 commit into
Conversation
…ilarity threshold races,
nil dereferences, and inverted active user default
Signed-off-by: Shaheem Azmal M MD <shaheem.azmal@gmail.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
deo002
requested changes
May 29, 2026
|
|
||
| if err := json.Unmarshal(bytes, &ext); err != nil { | ||
| panic(err) | ||
| log.Printf("failed to unmarshal external_ref for license %v: %v", dto.Shortname, err) |
Collaborator
There was a problem hiding this comment.
zap logger must be used and in this implementation, function won't stop execution after an error
| } | ||
| parsed, err := strconv.ParseFloat(thresholdStr, 64) | ||
| if err != nil { | ||
| log.Printf("Invalid SIMILARITY_THRESHOLD '%s', using default %.1f", thresholdStr, defaultThreshold) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
correct UUID nil checks in obligation hooks (.Id.String() == "" || == uuid.Nil),
fix category validation checking wrong field (Classification.Id = Category.Id),
replace base64.StdEncoding with base64.RawURLEncoding in GetKid (restoring OIDC auth),
fix inverted active default in GetAllUser (was returning inactive users),
guard NIL UserEmail/UserName dereferences in email notifications, and
remove panic(err) on ExternalRef JSON unmarshal.