[RTE-608] Remove mopa crate from the cargo#838
Merged
Conversation
Taowyoo
previously approved these changes
Nov 12, 2025
Taowyoo
reviewed
Nov 12, 2025
Collaborator
There was a problem hiding this comment.
Nit:
You need to bump version if need to publish new version.
(This could be done in separate PR.)
Member
Author
There was a problem hiding this comment.
I just update it now so to not make a separate PR. Thanks for noting this. :)
0607833 to
e1cf7c7
Compare
- Remove `mopa` dependency - Update version of `sgxs-tools` and Cargo.lock - Eliminate Dependabot alert 5 and 40
e1cf7c7 to
1ffbc87
Compare
raoulstrackx
approved these changes
Nov 13, 2025
Contributor
|
Nit: I forgot to add this, but when adding modern compiler features, it might be worthwhile setting the For example, if I try to install a crate that has a higher MSRV than my selected toolchain, I get: cargo install --path . ✔
Installing msrv-test v0.0.0 (/home/thomas/rust-toy)
error: failed to compile `msrv-test v0.0.0 (/home/thomas/rust-toy)`, intermediate artifacts can be found at `/home/thomas/rust-toy/target
`.
To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.
Caused by:
rustc 1.80.0-nightly is not supported by the following package:
msrv-test@0.0.0 requires rustc 1.86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mopais used only insgx-detecttool, as a legacy workaround on generic programming with polymorphic types. Newer Rust now supports type upcasting, allowingstd::any::Anyto be used instead of usingmopa::Any.This should fix the Dependabot alert related to
mopacrate:Credit fo solution: @tvsfx
Verified the tools are working on the SGX machine.