chore(charts): update chart versions for Cloudprem, Console-V3, Forma…#398
chore(charts): update chart versions for Cloudprem, Console-V3, Forma…#398reslene wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (9)
📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (3)
WalkthroughUpdated the root Helm chart version table and four chart README badges for the Cloudprem, Console-V3, Formance, and Portal releases. ChangesChart release metadata
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🛑 Changes requested — automated reviewThe PR performs a chart version cascade for Cloudprem, Console-V3, and Forma charts, which appears consistent. However, the standalone membership chart's Chart.lock file has been refreshed (updating the locked PostgreSQL subchart dependency) while charts/membership/Chart.yaml remains at version 3.6.2. This creates a conflict with the repository's immutable chart release workflow: the release pipeline uses --skip-existing, so no new membership artifact will be published, yet building from source would yield a different 3.6.2 artifact than the already-published one. This must be resolved by either reverting the Chart.lock change or bumping the membership chart version and regenerating all derived files. Findings outside the diff🟠 [major] Membership Chart.lock changed without a corresponding chart version bump — The standalone membership chart's locked PostgreSQL subchart dependency has been refreshed in Chart.lock, but charts/membership/Chart.yaml still remains at version 3.6.2. The release workflow publishes immutable chart versions with --skip-existing, so no new membership chart artifact will be published. However, packaging from this source would produce a different 3.6.2 artifact than the already-published one, causing a mismatch between the repository and the published artifact. Suggestion: Either revert the Chart.lock change (if it was unintentional) or bump the membership chart version in Chart.yaml and regenerate all derived files so the updated dependency set is published under a new version. |
NumaryBot
left a comment
There was a problem hiding this comment.
NumaryBot posted 1 new inline finding.
Summary: #398 (comment)
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7b1307c027
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: postgresql | ||
| repository: oci://registry-1.docker.io/bitnamicharts | ||
| version: 18.7.13 | ||
| version: 18.8.0 |
There was a problem hiding this comment.
Bump membership for its lockfile refresh
This refreshes membership's locked PostgreSQL dependency while charts/membership/Chart.yaml remains at 3.6.2. The repo documents that any Chart.lock owner needs its own chart version bump, and the release flow publishes immutable chart versions with cr upload --skip-existing; without a new membership version, direct membership consumers will never receive this dependency update as a released chart, while source builds can produce a different 3.6.2 artifact. Please bump membership and regenerate the derived files.
Useful? React with 👍 / 👎.
…nce, and Portal to latest releases
7b1307c to
2153c2d
Compare
NumaryBot
left a comment
There was a problem hiding this comment.
🛑 Changes requested — automated review
The PR performs a chart version cascade for Cloudprem, Console-V3, and Forma charts, which appears consistent. However, the standalone membership chart's Chart.lock file has been refreshed (updating the locked PostgreSQL subchart dependency) while charts/membership/Chart.yaml remains at version 3.6.2. This creates a conflict with the repository's immutable chart release workflow: the release pipeline uses --skip-existing, so no new membership artifact will be published, yet building from source would yield a different 3.6.2 artifact than the already-published one. This must be resolved by either reverting the Chart.lock change or bumping the membership chart version and regenerating all derived files.
Findings outside the diff
🟠 [major] Membership Chart.lock changed without a corresponding chart version bump — charts/membership/Chart.lock:4 (NumaryBot, chatgpt-codex-connector[bot], codex)
The standalone membership chart's locked PostgreSQL subchart dependency has been refreshed in Chart.lock, but charts/membership/Chart.yaml still remains at version 3.6.2. The release workflow publishes immutable chart versions with --skip-existing, so no new membership chart artifact will be published. However, packaging from this source would produce a different 3.6.2 artifact than the already-published one, causing a mismatch between the repository and the published artifact.
Suggestion: Either revert the Chart.lock change (if it was unintentional) or bump the membership chart version in Chart.yaml and regenerate all derived files so the updated dependency set is published under a new version.
Summary: #398 (comment)
…nce, and Portal to latest releases