-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(web): native browser fullscreen via the Fullscreen API #946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ortes
wants to merge
4
commits into
fluttercommunity:master
Choose a base branch
from
Ortes:feat/web-native-fullscreen
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
86d9425
feat: native browser fullscreen on web
Ortes 79472b7
Gate native web fullscreen behind useNativeFullScreenOnWeb flag
Ortes 05b5e59
Address review: abstract web fullscreen import, drop lint ignore
Ortes 115e7cb
Merge remote-tracking branch 'upstream/master' into feat/web-native-f…
Ortes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| import 'dart:js_interop'; | ||
|
|
||
| import 'package:web/web.dart' as web; | ||
|
|
||
| final _handlers = <void Function(), JSFunction>{}; | ||
|
|
||
| void requestBrowserFullscreen() { | ||
| web.document.documentElement?.requestFullscreen(); | ||
| } | ||
|
|
||
| void exitBrowserFullscreen() { | ||
| if (web.document.fullscreenElement != null) { | ||
| web.document.exitFullscreen(); | ||
| } | ||
| } | ||
|
|
||
| bool get browserInFullscreen => web.document.fullscreenElement != null; | ||
|
|
||
| void addBrowserFullscreenChangeListener(void Function() callback) { | ||
| final jsHandler = ((JSAny? _) => callback()).toJS; | ||
| _handlers[callback] = jsHandler; | ||
| web.document.addEventListener('fullscreenchange', jsHandler); | ||
| } | ||
|
|
||
| void removeBrowserFullscreenChangeListener(void Function() callback) { | ||
| final jsHandler = _handlers.remove(callback); | ||
| if (jsHandler != null) { | ||
| web.document.removeEventListener('fullscreenchange', jsHandler); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| void requestBrowserFullscreen() {} | ||
| void exitBrowserFullscreen() {} | ||
| bool get browserInFullscreen => false; | ||
| void addBrowserFullscreenChangeListener(void Function() callback) {} | ||
| void removeBrowserFullscreenChangeListener(void Function() callback) {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.