Skip to content

Reduce size of pictures to be ~25K each.#942

Merged
polina-c merged 12 commits into
flutter:mainfrom
polina-c:pictures
May 28, 2026
Merged

Reduce size of pictures to be ~25K each.#942
polina-c merged 12 commits into
flutter:mainfrom
polina-c:pictures

Conversation

@polina-c
Copy link
Copy Markdown
Collaborator

@polina-c polina-c commented May 28, 2026

Screenshot 2026-05-27 at 5 48 33 PM

@polina-c polina-c changed the title Pictures Reduce size of pictures to be ~50K each. May 28, 2026
@github-actions
Copy link
Copy Markdown

Package publishing

Package Version Status Publish tag (post-merge)
package:a2ui_core 0.0.1-dev002 already published at pub.dev
package:genai_primitives 0.2.4-dev001 ready to publish genai_primitives-v0.2.4-dev001
package:genui 0.9.1 ready to publish genui-v0.9.1
package:genui_a2a 0.9.0 already published at pub.dev
package:json_schema_builder 0.1.4 ready to publish json_schema_builder-v0.1.4

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the image asset filenames in the climbing database to use a consistent naming convention (e.g., mountain_01.jpeg). Additionally, it removes unused macOS dependencies (audioplayers_darwin, url_launcher_macos, and video_player_avfoundation) from the Podfile and updates the Xcode project configuration accordingly. I have no feedback to provide on these changes.

@polina-c polina-c requested review from ditman and yjbanov May 28, 2026 00:51
Copy link
Copy Markdown
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we should strip them off the repo (?)

33CC10EB2044A3C60003C045 /* Resources */,
33CC110E2044A8840003C045 /* Bundle Framework */,
3399D490228B24CF009A79C7 /* ShellScript */,
9322B9AAFF826A47D53233CB /* [CP] Embed Pods Frameworks */,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't expect these changes in this PR? (I'm assuming these files got recreated when you ran the app on a mac?)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably related: #929

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is part of the process - these files are changed from time to time.

@andrewkolos , thank you for filing the issue. It should be resolved at some moment, but for now the files are part of PRs.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do all the images have a weird border around them?

Copy link
Copy Markdown
Collaborator

@andrewkolos andrewkolos May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be artifacts of a manual screen capture. Regardless, here's a script that can remove them and then resizes images to the lowest common size:

brew install imagemagick

cd examples/simple_chat/assets/climbing
for f in mountain_*.jpeg; do
  magick "$f" -shave 3x3 +repage -gravity center -extent 486x323 +repage -quality 92 "$f.tmp" && mv "$f.tmp" "$f"
done

LLM-generated explanation:

  • -shave 3x3 — chops 3px off every side (removes the snipping-tool border)
  • +repage — resets canvas metadata so the shave is permanent
  • -gravity center -extent 486x323 — center-crops to the minimum common size across all 20
  • -quality 92 — re-encode at quality 92 (visually indistinguishable from the input)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

it was manually cut by agent :)

will fix

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neato! FWIW I still see image borders in GitHub but I think that's just the UI--they look fine when opened in a new tab or locally. LGTM

@polina-c polina-c requested review from andrewkolos and ditman May 28, 2026 17:02
Copy link
Copy Markdown
Collaborator

@andrewkolos andrewkolos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polina-c polina-c changed the title Reduce size of pictures to be ~50K each. Reduce size of pictures to be ~25K each. May 28, 2026
@polina-c polina-c merged commit 0588a45 into flutter:main May 28, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants