Reduce size of pictures to be ~25K each.#942
Conversation
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
There was a problem hiding this comment.
Code Review
This pull request updates the image asset filenames in the climbing database to use a consistent naming convention (e.g., mountain_01.jpeg). Additionally, it removes unused macOS dependencies (audioplayers_darwin, url_launcher_macos, and video_player_avfoundation) from the Podfile and updates the Xcode project configuration accordingly. I have no feedback to provide on these changes.
ditman
left a comment
There was a problem hiding this comment.
Ideally we should strip them off the repo (?)
| 33CC10EB2044A3C60003C045 /* Resources */, | ||
| 33CC110E2044A8840003C045 /* Bundle Framework */, | ||
| 3399D490228B24CF009A79C7 /* ShellScript */, | ||
| 9322B9AAFF826A47D53233CB /* [CP] Embed Pods Frameworks */, |
There was a problem hiding this comment.
I wouldn't expect these changes in this PR? (I'm assuming these files got recreated when you ran the app on a mac?)
There was a problem hiding this comment.
Yes, it is part of the process - these files are changed from time to time.
@andrewkolos , thank you for filing the issue. It should be resolved at some moment, but for now the files are part of PRs.
There was a problem hiding this comment.
Why do all the images have a weird border around them?
There was a problem hiding this comment.
Might be artifacts of a manual screen capture. Regardless, here's a script that can remove them and then resizes images to the lowest common size:
brew install imagemagick
cd examples/simple_chat/assets/climbing
for f in mountain_*.jpeg; do
magick "$f" -shave 3x3 +repage -gravity center -extent 486x323 +repage -quality 92 "$f.tmp" && mv "$f.tmp" "$f"
doneLLM-generated explanation:
-shave 3x3— chops 3px off every side (removes the snipping-tool border)+repage— resets canvas metadata so the shave is permanent-gravity center -extent 486x323— center-crops to the minimum common size across all 20-quality 92— re-encode at quality 92 (visually indistinguishable from the input)
There was a problem hiding this comment.
thanks
it was manually cut by agent :)
will fix
There was a problem hiding this comment.
Neato! FWIW I still see image borders in GitHub but I think that's just the UI--they look fine when opened in a new tab or locally. LGTM
Uh oh!
There was an error while loading. Please reload this page.